Skip to content

chore: [Bigtable] configure grpc service config for PHP Bigtable - #9601

Open
gcf-owl-bot[bot] wants to merge 6 commits into
mainfrom
owl-bot-copy-Bigtable
Open

chore: [Bigtable] configure grpc service config for PHP Bigtable#9601
gcf-owl-bot[bot] wants to merge 6 commits into
mainfrom
owl-bot-copy-Bigtable

Conversation

@gcf-owl-bot

@gcf-owl-bot gcf-owl-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
  • Regenerate this pull request now.

PiperOrigin-RevId: 972068784

Source-Link: googleapis/googleapis@1182557

Source-Link: https://github.com/googleapis/googleapis-gen/commit/44cbd81232e3b93b394628be36ac3520ce6baaee
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjQ0Y2JkODEyMzJlM2I5M2IzOTQ2MjhiZTM2YWMzNTIwY2U2YmFhZWUifQ==

PiperOrigin-RevId: 972068784

Source-Link: googleapis/googleapis@1182557

Source-Link: googleapis/googleapis-gen@44cbd81
Copy-Tag: eyJwIjoiQmlndGFibGUvLk93bEJvdC55YW1sIiwiaCI6IjQ0Y2JkODEyMzJlM2I5M2IzOTQ2MjhiZTM2YWMzNTIwY2U2YmFhZWUifQ==
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot
gcf-owl-bot Bot marked this pull request as ready for review August 27, 2026 21:01
@gcf-owl-bot
gcf-owl-bot Bot requested review from a team as code owners August 27, 2026 21:01
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 27, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@JoeWang1127

JoeWang1127 commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The Bigtable conformance test TestMutateRow_Generic_DeadlineExceeded failed after introducing the gRPC service configuration. With the new retry policy, MutateRow now treats DEADLINE_EXCEEDED as retryable.

During the test, a 2-second perOperationTimeout is configured against a mock server with a 10-second sleep. Previously, the test proxy only passed timeoutMillis without specifying retrySettings.totalTimeoutMillis.

When the initial 2-second call timed out with DEADLINE_EXCEEDED, GAX fell back to the default 60-second total timeout and initiated a retry. The Go mock server in cloud-bigtable-clients-test was only configured for a single request, causing a nil pointer dereference panic when the unexpected retry request arrived.

Fix this by setting retrySettings.totalTimeoutMillis in ProxyService::MutateRow, aligning it with other retryable methods (ReadRow, ReadRows, BulkMutateRows) so that GAX respects the total per-operation deadline and ceases retrying once the timeout is reached.

@trusted-contributions-gcf trusted-contributions-gcf Bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant