fix(storage): add retry support for finalize and close in AsyncAppendableObjectWriter#17733
Open
sahusneha2004 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for custom and default retry policies during the finalization and closing of an asynchronous appendable object writer, along with corresponding unit tests. However, the current implementation of the retry mechanism in finalize is flawed because it attempts to reuse the same gRPC stream (write_obj_stream) after an error has occurred. In production, a gRPC stream enters an errored state and closes upon failure, meaning subsequent retries on the same stream will fail immediately. To resolve this, the underlying stream must be re-established or recreated before retrying.
sahusneha2004
force-pushed
the
fix-appendable-writer-finalize-retry
branch
from
July 16, 2026 10:22
25ddefa to
208879e
Compare
…ableObjectWriter Fixes: b/532527637
sahusneha2004
force-pushed
the
fix-appendable-writer-finalize-retry
branch
from
July 16, 2026 10:34
208879e to
3366eb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: b/532527637