fix: require Protobuf 6.33.5+#17743
Draft
parthea wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the minimum protobuf version requirement to 6.33.5 across multiple packages and configuration files. It also removes support for the 'cpp' protobuf implementation and cleans up associated test configurations and legacy logic. A review comment suggests removing a redundant parameterized test case in packages/google-api-core/noxfile.py to improve code cleanliness.
Comment on lines
301
to
306
| # TODO: Remove once we stop support for protobuf 4.x. | ||
| ( | ||
| True, | ||
| False, | ||
| ["3.10", "3.11"], | ||
| 4, | ||
| ), # Run proto4 tests with grpcio/grpcio-gcp installed |
Contributor
There was a problem hiding this comment.
This parameterized test case is redundant as it is a subset of the first test case (True, False, None). Please remove this block to avoid code redundancy.
References
- Remove duplicate lines of code, especially duplicate assertions in tests, to keep the codebase clean and avoid redundancy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/420641246