Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the get_field_name helper function in the bigquery-derive crate to return a syn::Result<String> instead of a String, allowing proper propagation of parsing errors for invalid bigquery attributes. It also updates derive_from_row and derive_from_sql to validate all fields upfront and return compile errors if any attribute parsing fails, and adds corresponding unit tests to verify this behavior. There are no review comments, and I have no additional feedback to provide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6876 +/- ##
==========================================
- Coverage 97.17% 97.17% -0.01%
==========================================
Files 329 329
Lines 110459 110484 +25
==========================================
+ Hits 107344 107366 +22
- Misses 3115 3118 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Fail compilation if there is an invalid macro attribute. (Previously it succeeded silently).
Fixes #6875