Skip to content

cleanup(bigquery): fix column name in usa_names rustdoc examples - #6883

Open
dbolduc wants to merge 1 commit into
googleapis:mainfrom
dbolduc:fix-bigquery-doc-examples
Open

dbolduc wants to merge 1 commit into
googleapis:mainfrom
dbolduc:fix-bigquery-doc-examples

Conversation

@dbolduc

@dbolduc dbolduc commented Sep 20, 2026

Copy link
Copy Markdown
Member

Fixes #6882

@product-auto-label product-auto-label Bot added the api: bigquery Issues related to the BigQuery API. label Sep 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation examples in src/bigquery/src/lib.rs and src/bigquery/src/query/client.rs to use the field name 'number' instead of 'count' in the SQL queries, struct definitions, and output printing. There are no review comments, and I have no feedback to provide.

@dbolduc
dbolduc marked this pull request as ready for review September 20, 2026 04:35
@dbolduc
dbolduc requested a review from a team as a code owner September 20, 2026 04:35
@dbolduc
dbolduc enabled auto-merge (squash) September 20, 2026 04:35
@codecov

codecov Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.17%. Comparing base (2edb4a6) to head (a74991b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6883   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files         326      326           
  Lines      110145   110145           
=======================================
+ Hits       107034   107037    +3     
+ Misses       3111     3108    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc changed the title docs(bigquery): fix column name in usa_names rustdoc examples cleanup(bigquery): fix column name in usa_names rustdoc examples Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BQ Query: Example has wrong column name

1 participant