Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jupyter-kernel-client v1.0.0 renamed `KernelClient` to `JupyterKernelClient`.
The fallback `else` branch in runtime.py still calls the old name, causing:
AttributeError: module 'jupyter_kernel_client' has no attribute 'KernelClient'
Fix: use getattr with fallback to JupyterKernelClient so both old (<1.0.0)
and new (>=1.0.0) versions of jupyter-kernel-client work correctly.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dpaul0501
force-pushed
the
fix/jupyter-kernel-client-rename-KernelClient
branch
from
September 18, 2026 10:10
f2a1c7b to
740a492
Compare
Collaborator
|
#125 merged and fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
jupyter-kernel-clientv1.0.0 renamedKernelClient→JupyterKernelClient. Theelsebranch inruntime.pystill references the old name, causing everycolab run,colab exec,colab install, andcolab sessionscommand to fail with:This affects any user who has
jupyter-kernel-client >= 1.0.0installed (e.g. via Homebrew Python or a fresh pip install).Fix
Use
getattrwith a fallback toJupyterKernelClientso both old (< 1.0.0) and new (>= 1.0.0) versions of the dependency work:Tested
Verified on macOS with
jupyter-kernel-client==1.0.2—colab sessionsandcolab runno longer throwAttributeError.🤖 Generated with Claude Code