Repository navigation
Guard configuration inspection reads with the data lock - #235
Merged
inhere merged 1 commit intoOct 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetDatareplaces the config data under its write lock, butExists,Keys, andIsEmptyread that data without taking the corresponding read lock. Calling these inspection methods alongsideSetDataproduces data races;GetValuealready takes the lock and passes the same concurrent control.This adds read guards to the three inspection methods. The regression tests exercise concurrent map replacement and inspection, check that each read sees a complete configuration, and call the inspection methods from write hooks to guard against deadlocks.
DataandSubretain their existing live-map behavior.Validation on Go 1.26.0 / macOS arm64:
-raceafter it, including five focused repetitions.go vet ./...andgo build ./...pass.issues_test.go(the deprecatedyamlv3import and two duration-variable names). No new findings or suppressions.The Ubuntu/Go-version matrix and GitHub checks have not been run locally.