Repository navigation
Allow writes after SetData(nil) - #237
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
SetData(nil), reads see an empty configuration, but writing a top-level or literal dotted key panics on assignment to the nil root map. Nested writes already initialize their path.Initialize the missing root map inside the existing locked write path. Readonly/invalid-key checks still reject before allocation, and hooks/cache behavior is unchanged.
Go 1.26.0 / macOS arm64 validation:
Module files are unchanged. Other supported Go/OS combinations remain unverified locally; this does not add broader external-map ownership or read-side concurrency guarantees.