You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The alpha.term extension deletes the terminal buffer on AlphaClosed, which causes an Invalid window id: ... error when the plugin tries to redraw things. This PR makes it so that it sets the redraw option back to true when the Alpha buffer is closed. Doing it this way still avoids the infinite redraw problem that this flag was preventing.
ah, i see the problem now, but i'm pretty sure this is like using a shotgun to kill a fly. the terminal buffer should just get redrawn when you open alpha back up
@goolord I've found that something spams the WinResized event whenever Alpha opens back up a second time, which cause Alpha to redraw over & over & over again because of this autocmd.
I cannot figure out what's causing the deluge of WinResized events though. Any ideas?
Hmm, if I disable the terminal element, then the event no longer spams. So it could be something in what the terminal element does that causes its own issue...
Hi @goolord, can you please expound on the terminal buffer should just get redrawn when you open alpha back up?
Isn't this what this PR achieves? The opt.redraw = false rightfully prevents the terminal from rerunning again during window resizes while Alpha is open, for example. In such cases the element is simply repositioned. This PR marks the element to be redrawn the next time Alpha is opened. Am I misunderstanding your ask?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
alpha.termextension deletes the terminal buffer onAlphaClosed, which causes anInvalid window id: ...error when the plugin tries to redraw things. This PR makes it so that it sets theredrawoption back totruewhen the Alpha buffer is closed. Doing it this way still avoids the infinite redraw problem that this flag was preventing.This should solve the issue reported here: #275