fix(plugin-e2e): support new root OFREP route - #2848
Merged
Conversation
MattIPv4
requested review from
academo,
oshirohugo and
xnyo
and removed request for
a team
August 21, 2026 15:29
grafana-catalog-project-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
sunker
reviewed
Aug 21, 2026
sunker
left a comment
sunker
left a comment
Contributor
There was a problem hiding this comment.
Nice. Is the namespace less route tied to a specific Grafana version, or can it show up on stacks reporting the same version as the old route? If it's version specific, might be cleaner to add it as a new versioned key in ofrepBulkPath/ofrepSinglePath (like DataSource.health already does) instead of the dual URL fallback in the fixture.
Member
Author
It is behind a feature flag (grafana/grafana#130255 + grafana/grafana#130254), so no specific version as far as I know. |
Contributor
|
Think the CI failures will be solved if you sync with main. |
MattIPv4
force-pushed
the
MattIPv4/new-ofrep-route
branch
from
August 21, 2026 17:58
1e34dfc to
f4cf7b1
Compare
sunker
approved these changes
Aug 24, 2026
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Grafana is switching to using a namespace-less OFREP route at the root path, which the current E2E logic does not catch to override responses.