Repository navigation
A new website is in the scopes the same request reads after it - #9
Merged
Merged
Conversation
StoreManager::reinitStores() cleans the store, website and group tags
through the config cache type, and that tag scope only drops entries that
also carry the config type's tag. FASTBOOT_SCOPES and
FASTBOOT_WEBSITE_STORES_* carried the store tags only, so they survived
the reinit and the scopes reloaded right after came back without the new
website. Creating a website then failed Inventory's sales channel
validation ("The website with code ... does not exist").
Tag both entries with the config cache tag as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StoreManager::reinitStores()cleans the store, website and group tags through the config cache type, and that clean only drops entries that also carry the config type's tag.FASTBOOT_SCOPESandFASTBOOT_WEBSITE_STORES_*carried the store tags only, so they survived the reinit. Creating a website then failed Inventory's sales channel validation ("The website with code ... does not exist").Both entries now carry the config cache tag too.
StoreReinitTestcovers it.This fix moves out of the vendor patch in
graphcommerce-org/project-catalogreadmodel(patches/graphcommerce-magento-fast-boot-scopes-follow-store-reinit.patch). The project drops the patch after this is merged.🤖 Generated with Claude Code
https://claude.ai/code/session_01P4jLu4fTNqMe3WuJern5CW
Generated by Claude Code