Branch naming validation

[vladysta]

I'm in love at first sight with this repo ❤️

My idea is to validate branch name against some pattern

so for example,
as I personally mostly use git flow.

Plus I want to see ticket number as a part of the branch
so I write this regex

^(feature|hotfix|bugfix|release)\/(ABC\-)\d{1,}\-[a-zA-Z]+

which will match this one

feature/ABC-3-asddas

[greg0ire]

Oh wow thanks that's humbling, really!

Regarding the branch naming validation, when should it be performed? On creation, before push, something else? Maybe it should be configurable?

[vladysta]

I think, before push is the right one. Because if it's incorrect, you can easily change the name with

git checkout -b new-branch-name

[Edo78]

I think it would be better to check on creation

[greg0ire]

git checkout -b new-branch-name

Or git branch -m

Anyway, both things can be done, and we can let the user choose on what event they want the check to happen, maybe?

[vladysta]

@greg0ire yes.

I just don't want to over engeneer

[greg0ire]

Here is how it's done for make in case you are wondering:

git_template/template/hooks/make/pre-push

Lines 6 to 8 in 820f947

	get_hook_config make on hooks optional "pre-push"
	if echo "$hooks"|grep --quiet pre-push > /dev/null

git_template/template/hooks/make/pre-commit

Lines 6 to 8 in 820f947

	get_hook_config make on hooks optional "pre-push"
	if echo "$hooks"|grep --quiet pre-commit > /dev/null