Repository navigation
feat: migration web components layout - #31
Merged
Merged
Conversation
Zlodej43sm
commented
Oct 19, 2026
Zlodej43sm
commented
Collaborator
- migration web components layout
- rework stories
- improve storybook
- Add comprehensive play tests for Scroll component (vertical, horizontal, auto-hide variants) - Fix skeleton keyframe rendering with `cssKeyframesToText` utility - Compose `gd-loader` in button loading state instead of inline spinner - Export layout components from index - Enforce story parity validation: check all components have matching React story inventory, descriptions, and titles - Prevent Web Component stories from containing React/migration language - Validate loader composition in loading states across all components - Update Typography to support webComponent token overrides - Fix story source formatter to handle nested elements correctly - Add layout components to SSR test surface
- Add aria-labels to inputs, buttons, and interactive controls (InputFile, Slider, RadioGroup, Carousel) - Fix skeleton theme resolution to match React behavior by excluding colors/animations from token theme - Add non-breaking space to skeleton slot default to ensure height in empty state - Change Snackbar close button from div to button element - Fix Link disabled state: add tabIndex and aria-disabled, improve className concatenation - Update RadioGroup label color token from caption to title for better contrast - Replace named colors with hex values in Row/Column stories for WCAG compliance - Add alt attributes to Card and Carousel images - Fix Chart role to 'group' when legend is interactive - Add skeleton-story-parity test coverage
Delete entire design-core library (package.json, project config, source) and remove migration manifest documentation for layout-structure, loader-separator-skeleton, slider-controls, and toggle-truncate-typography-wrapper components.
… notes from stories Apply per-size Typography variants to avatar fallback text matching source component behavior. Change Icon, Box, and Link hosts to `display: contents` to avoid adding layout boxes. Forward Box styles to internal root and make it the focus target. Register custom icons API. Apply Box styles to Icon svg element. Update test coverage for layout transparency, focus delegation, and Typography composition.
… notes from stories Apply per-size Typography variants to avatar fallback text matching source component behavior. Change Icon, Box, and Link hosts to `display: contents` to avoid adding layout boxes. Forward Box styles to internal root and make it the focus target. Register custom icons API. Apply Box styles to Icon svg element. Update test coverage for layout transparency, focus delegation, and Typography composition.
…-components-layout # Conflicts: # libs/ui/src/icons/catalog.spec.ts
Add `check:story-parity` and `check:story-parity:browser` scripts to validate that Web Component stories match React story inventory, descriptions, and titles. Browser variant opens interactive report.
Type the Textarea argType helper with Storybook's InputType, cast the InputFile mock arg in clearMock, and add DOM.Iterable to the storybook tsconfig so NodeList iteration type-checks. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Zlodej43sm
marked this pull request as ready for review
October 20, 2026 06:38
Change test selector from generic 'Button' to 'Disabled Button' to match the actual accessible name in the atoms-button--disabled-button story.
Use regex matcher for input with helper text (accessible name includes "Label Helper text" from wrapping label) and remove overly-specific name matcher for read-only input test.
Intercept `gd-*` custom events by patching `dispatchEvent` instead of relying on story `<output>` elements. Wait for Storybook play functions to complete before running checks to avoid race conditions. Update test assertions to match current story data (option names, values, and initial states).
rcasian
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.