add voltage regulation for battery creation - #850
Conversation
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughBattery creation now persists and reconstructs voltage regulation settings, including target voltage and regulating terminal identifiers. Liquibase adds the corresponding columns, creation tests populate the new fields, and the network modification dependency uses version ChangesBattery voltage regulation persistence
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.java`:
- Around line 70-71: Change the voltageRegulationOn field in
BatteryCreationEntity from primitive boolean to boxed Boolean so existing
database NULL values can be mapped safely. Preserve the existing column mapping
and update any directly dependent handling only as needed to support nullable
values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 642a3642-5660-44cd-82d8-cc4f7c8000f8
📒 Files selected for processing (6)
pom.xmlsrc/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.javasrc/main/resources/db/changelog/changesets/changelog_20260716T122908Z.xmlsrc/main/resources/db/changelog/db.changelog-master.yamlsrc/test/java/org/gridsuite/modification/server/modifications/BatteryCreationInBusBreakerTest.javasrc/test/java/org/gridsuite/modification/server/modifications/BatteryCreationInNodeBreakerTest.java
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
PR Summary