Skip to content

add voltage regulation for battery creation - #850

Open
EtienneLt wants to merge 8 commits into
mainfrom
add-voltage-regulation-for-battery-creation
Open

add voltage regulation for battery creation#850
EtienneLt wants to merge 8 commits into
mainfrom
add-voltage-regulation-for-battery-creation

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9026ba31-3cf6-4e57-bd7c-02bbc813a32c

📥 Commits

Reviewing files that changed from the base of the PR and between 736d1f0 and e911529.

📒 Files selected for processing (3)
  • pom.xml
  • src/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.java
  • src/main/resources/db/changelog/db.changelog-master.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.java
  • src/main/resources/db/changelog/db.changelog-master.yaml

📝 Walkthrough

Walkthrough

Battery creation now persists and reconstructs voltage regulation settings, including target voltage and regulating terminal identifiers. Liquibase adds the corresponding columns, creation tests populate the new fields, and the network modification dependency uses version 1.3.0-SNAPSHOT.

Changes

Battery voltage regulation persistence

Layer / File(s) Summary
Battery persistence fields and schema
src/main/java/.../BatteryCreationEntity.java, src/main/resources/db/changelog/...
BatteryCreationEntity maps voltage regulation attributes through assignment and reconstruction, while Liquibase adds and registers the matching battery_creation columns.
Battery creation fixture updates
src/test/java/.../BatteryCreationInBusBreakerTest.java, src/test/java/.../BatteryCreationInNodeBreakerTest.java, pom.xml
Battery creation fixtures set voltage regulation values, and the network-modification dependency version is updated to 1.3.0-SNAPSHOT.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is only a template placeholder and does not meaningfully describe the changeset. Replace the placeholder with a brief summary of the battery voltage regulation and schema changes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding voltage regulation support for battery creation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.java`:
- Around line 70-71: Change the voltageRegulationOn field in
BatteryCreationEntity from primitive boolean to boxed Boolean so existing
database NULL values can be mapped safely. Preserve the existing column mapping
and update any directly dependent handling only as needed to support nullable
values.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 642a3642-5660-44cd-82d8-cc4f7c8000f8

📥 Commits

Reviewing files that changed from the base of the PR and between 2b0fc20 and 736d1f0.

📒 Files selected for processing (6)
  • pom.xml
  • src/main/java/org/gridsuite/modification/server/entities/equipment/creation/BatteryCreationEntity.java
  • src/main/resources/db/changelog/changesets/changelog_20260716T122908Z.xml
  • src/main/resources/db/changelog/db.changelog-master.yaml
  • src/test/java/org/gridsuite/modification/server/modifications/BatteryCreationInBusBreakerTest.java
  • src/test/java/org/gridsuite/modification/server/modifications/BatteryCreationInNodeBreakerTest.java

EtienneLt and others added 3 commits July 17, 2026 08:26
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Mathieu-Deharbe

This comment was marked as resolved.

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants