Skip to content

session-notes: 2026-10-25 grind #451 + #454 #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
growlf merged 1 commit into from
Oct 25, 2026
Merged

session-notes: 2026-10-25 grind #451 + #454 #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions docs/session-notes/2026-10-25.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,38 @@ deliverable disappeared. Added `test_command_carries_the_output_contract`

No infrastructure changes. Provider config edits were temporary and reverted;
the proxy was stopped and its port freed before the session ended.

### 2. Grind: #451 + #454 (PRs #451 + #456)

Two issues processed through the grind workflow:

**#451 — `check-worktree.sh` primary checkout detection fix** (PR #451, squash
`615cd34`): The script used to derive a "primary path" from the script's own
location and compare it against `git worktree list`, which always matched the
worktree the caller was standing in — so every worktree commit printed "in the
primary checkout", and the genuine case (primary checkout left on a feature
branch) was buried under noise. Fixed by using `git rev-parse --git-common-dir`
vs `--absolute-git-dir` (identical only in the primary checkout). Also fixed the
`GREEN` color variable bug that was hidden by the detection bug. 8 real-repo
tests added. The PR included collateral changes (Caddyfile redirect support, 2
KB articles) merged together per operator preference.

**#454 — 33 dead global skill symlinks** (PR #456, squash `44d20af`): All 45
entries in `~/.config/opencode/skills/` were symlinks; 33 pointed into a deleted
worktree (`opskit-wt-437`), making them dead. Added
`bin/check-global-skills.sh` — a doctor script that reports broken links
(`--check`, exit 1 if found) and repoints them to the main checkout (`--fix`).
The 33 broken symlinks were manually repointed during this session; 0 remain
broken. 4 tests added.

## Uncommitted work (not mine)

These files are present on main checkout, from other sessions:

- `.opencode/skills/lfnw-linkedin-photo/` (untracked dir)
- `.tmp/`, `Knoah.md`, `bin/.tmp/`, `worktrees/` (untracked dirs)
- `argparse`, `json`, `os`, `subprocess`, `sys`, `threading` (untracked files —
likely accidental shell redirects from a mangled command)
- `bin/bwunlock.sh` (modified), `docs/ideas.md` (staged)

Not touched during this session.
Loading