Conversation
Rename set_latest_microversion to set_request_microversion_header and rewrite to use endpoint.api_version() as the microversion value sent in the OpenStack-API-Version header. Previously the function used service_endpoint.version() (URL-parsed, always 2.1 for compute), ignoring the actual microversion the generated struct requires. Add bounds validation: if the endpoint's required microversion falls outside the cloud's discovered min/max range, return a new ApiError::MicroversionIncompatible error instead of sending a doomed request. The error carries required version and cloud range for a clear user-facing message. Add Copy, Eq, PartialOrd, Ord derives to ApiVersion to enable direct comparison. Reuse ApiVersion::from_apiver_str for parsing cloud min/max version strings instead of a custom parser. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
dialoguer forced every sdk_core consumer (including headless/server users) to compile a TTY prompt stack. Move Dialoguer impl into openstack-sdk-auth-core (already a dependency, no cycle), gated behind a new `interactive` feature (default-on, forwarded from sdk_core). sdk_core's auth_helper module re-exports it, so all downstream import paths stay unchanged. Also drop tokio-util (zero references in sdk_core) and inventory (dead there; real usage lives in auth-core/auth-* plugin crates), and move tokio to dev-dependencies (only used by #[tokio::test]). Removed OpenStackError::Dialoguer variant: never constructed anywhere in the workspace. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if mh_service_type.is_none() { | ||
| return Ok(()); | ||
| } | ||
| let st = mh_service_type.unwrap(); |
| (Some(mn), Some(mx)) => format!("{mn}..={mx}"), | ||
| (Some(mn), None) => format!("{mn}..*"), | ||
| (None, Some(mx)) => format!("*..={mx}"), | ||
| (None, None) => format!("*..*"), |
Comment on lines
+125
to
+134
| if let Some(min) = cloud_min { | ||
| if req_ver < min { | ||
| return Err(ApiError::microversion_incompatible( | ||
| req_ver.major, | ||
| req_ver.minor, | ||
| service_endpoint.min_version().clone(), | ||
| service_endpoint.max_version().clone(), | ||
| )); | ||
| } | ||
| } |
Comment on lines
+136
to
+145
| if let Some(max) = cloud_max { | ||
| if req_ver > max { | ||
| return Err(ApiError::microversion_incompatible( | ||
| req_ver.major, | ||
| req_ver.minor, | ||
| service_endpoint.min_version().clone(), | ||
| service_endpoint.max_version().clone(), | ||
| )); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dialoguer forced every sdk_core consumer (including headless/server
users) to compile a TTY prompt stack. Move Dialoguer impl into
openstack-sdk-auth-core (already a dependency, no cycle), gated
behind a new
interactivefeature (default-on, forwarded fromsdk_core). sdk_core's auth_helper module re-exports it, so all
downstream import paths stay unchanged.
Also drop tokio-util (zero references in sdk_core) and inventory
(dead there; real usage lives in auth-core/auth-* plugin crates),
and move tokio to dev-dependencies (only used by #[tokio::test]).
Removed OpenStackError::Dialoguer variant: never constructed anywhere
in the workspace.