fix type issue with laser on/off - #5
Open
vmagro wants to merge 1 commit into
Open
Conversation
I'm pretty sure this used to work, but now it seems that the cutter mode is being given as a string (gotta love JS). I updated the switches to operate on the value `.toString()` so that it works in the case of integer or string input types.
nakanotakuo
pushed a commit
to nakanotakuo/mpcnc_post_processor
that referenced
this pull request
Jul 24, 2026
setSpindeSpeed() only compared the requested speed against currentSpindleSpeed, so reversing spindle direction (clockwise <-> counterclockwise) while RPM stayed the same silently emitted no G-code. Added currentSpindleClockwise to track direction alongside speed, and re-trigger spindleOn() when direction changes while the spindle is running. Marks guffy1234#5 fixed in docs/known-issues-v4.md.
flyfisher604
added a commit
to flyfisher604/mpcnc_post_processor
that referenced
this pull request
Aug 18, 2026
Nine marker lines sat at the foot of comment blocks that the previous two passes rewrote, and the rewrites did not carry them forward: guffy1234#5 lost both halves, and #2, #3, #9, #11, #12, #13, #16 and #18 lost their validateJob() side. A pair with one half missing is exactly what the numbering exists to make visible, and "grep -oE '// TWIN #<n>' | wc -l" is the check -- every number must return 2. Also condenses the tool-change region's remaining blocks, which the previous pass did not reach: the flow overview, the two flows' hand-over and resume, the correction table and toolChangeMacroCall()'s four handler cases. No emitted text changes. All 190 integration cases pass, every posted .gcode is byte-identical to the run at the branch point, and stripping every comment from the post leaves it identical to the branch point line for line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm pretty sure this used to work, but now it seems that the cutter mode is
being given as a string (gotta love JS).
I updated the switches to operate on the value
.toString()so that it worksin the case of integer or string input types.