Repository navigation
ci(monorepo): make container deploys finish and verify the running image - #17
Merged
Merged
Conversation
- Keep the backend migration container from reading the deploy script on stdin, which ended the deploy before the API was recreated - Wait for the backend and MCP server containers to be ready after starting them - Fail the deploy when the running container does not use the released image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
backend/v1.12.4release (run 38062008463) reported a successful deploy, but production kept running the old backend container.The remote deploy script is passed to
bash -son stdin. Thedocker compose run ... --migratestep inherited that stdin and consumed the rest of the script, so bash exited with code 0 right after the migrations.docker compose upnever ran.Changes
-Tand</dev/nullso the rest of the script still runs.up --waitso the deploy waits for the containers to be ready.