Repository navigation
feat(backend): store production files on Amazon S3 - #18
Merged
Merged
Conversation
Pass the S3 bucket, region and IAM credentials to the API in the production overlay instead of relying on a server-only MinIO setup, and document the storage configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker-compose.prod.ymlpassesS3_BUCKET_NAME,S3_REGION,AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYto the API, with noStorage__ServiceUrl, so production uses Amazon S3 instead of the MinIO container..env.prod.examplelists the new variables.Storage:ServiceUrlselects MinIO vs S3 and the IAM permissions needed;docs/deployment.mdnotes that the deploy does not copy compose files to the server.No code changes:
S3FileStorageServicealready talks to S3, andattachments.storage_pathkeys are kept as-is during the file copy.Rollout
The server's compose files and
.envare updated by hand during the cutover (the deploy workflow does not copy them).