Repository navigation
ci(monorepo): require the DEPLOY_PATH secret - #23
Merged
Merged
Conversation
The backend and MCP deploys fell back to hard-coded paths when the DEPLOY_PATH secret was missing. The two defaults disagreed, the backend's did not match the deploy directory, and they exposed a server path in the public repository. Use the secret only and stop with a clear error when it is empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEPLOY_PATHonly from the secret, without a hard-coded fallback.The DEPLOY_PATH secret is not set.when it is empty, before connecting to the server.docs/deployment.mdmarks the secret as required.Why
The fallbacks were only used when the secret was missing, and then they caused problems:
The secret is already set, so current deploys behave the same.