Skip to content

refactor(bunny): use stable Bunny.v1.waitUntil - #304

Merged
pi0 merged 1 commit into
h3js:mainfrom
sandros94:chore/bunny-waitUntil-GA
Sep 14, 2026
Merged

pi0 merged 1 commit into
h3js:mainfrom
sandros94:chore/bunny-waitUntil-GA

Conversation

@sandros94

@sandros94 sandros94 commented Sep 14, 2026

Copy link
Copy Markdown
Member

just minor cleanup, as I was trying something related to waitUntil (potential PR followup)

Summary by CodeRabbit

  • Updates
    • Updated runtime integration to use the current Bunny.v1.waitUntil interface.
    • Removed the deprecated Bunny.unstable interface.
    • Updated developer documentation links to the current runtime documentation.

@sandros94
sandros94 requested a review from pi0 as a code owner September 14, 2026 09:55
@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown

@sandros94 is attempting to deploy a commit to the unjs Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5738c077-d097-465a-a337-989ba16d8334

📥 Commits

Reviewing files that changed from the base of the PR and between bae3e4e and 0b4eb8e.

📒 Files selected for processing (2)
  • src/adapters/bunny.ts
  • test/bunny.test.ts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Bunny adapter moves waitUntil from the removed unstable API to Bunny.v1, updates the public declarations and documentation link, and adjusts the delegation test.

Changes

Bunny waitUntil migration

Layer / File(s) Summary
v1 waitUntil contract and delegation
src/adapters/bunny.ts, test/bunny.test.ts
BunnySDKV1 now declares waitUntil. The adapter calls Bunny.v1.waitUntil. The test verifies the v1 delegation. The unstable export and type are removed. The documentation URL is updated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 0b4eb

This change consistently migrates Bunny waitUntil to the v1 API, with matching declarations and delegation coverage, and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Bunny adapter refactor and the move of waitUntil to the stable Bunny.v1 API. It matches the main change.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops where v1 calls,
waitUntil answers through new walls,
Old unstable paths fade away,
Tests follow the route today,
Bunny rests beneath the API sky.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/srvx@304

commit: 0b4eb8e

@pi0 pi0 changed the title chore(bunny): mark waitUntil as GA refactor(bunny): use stable Bunny.v1.waitUntil Sep 14, 2026
@pi0
pi0 merged commit 049efea into h3js:main Sep 14, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants