Repository navigation
ci: add typecheck/test/build gate on PR and main - #2
Merged
Merged
Conversation
Komodo builds + redeploys this service's image on every push to main (Deployment redeploy_on_build) with no check in between, so a broken merge ships straight to the alpha container. There was no CI at all. Add a GitHub Actions workflow that runs typecheck, tests, and a full tsc build on every PR and on main. Puppeteer's Chromium download is skipped (PUPPETEER_SKIP_DOWNLOAD) for speed/reliability — the render tests already self-skip when Chromium can't launch, so the suite stays green and fast while still covering the html/pdf/markdown conversion logic (incl. the html-to-markdown route from hadron-server#503). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Pull request overview
Adds a first CI “gate” workflow so PRs and main pushes must pass typecheck, tests, and a full TypeScript build before the repo’s auto-build/redeploy path can ship a broken change.
Changes:
- Add GitHub Actions workflow triggered on
pull_requestandpushtomain. - Run
npm ci,npm run typecheck,npm test(vitest), andnpm run build. - Skip Puppeteer’s Chromium download in CI via
PUPPETEER_SKIP_DOWNLOADwhile keeping browser-dependent tests self-skipping when Chromium can’t launch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Komodo builds + redeploys this service's image on every push to
main(Deploymentredeploy_on_build) with no check in between — and the repo had no CI at all. That's the "no gate" half of hadron-memory/hadron-server#503: the/convert/html-to-markdownroute was merged (2026-07-03) but never validated, and the stale image kept serving a 404 for web-page clips until it was manually rebuilt.What
A GitHub Actions workflow that runs on every PR and on
main:npm cinpm run typechecknpm testnpm run build(fulltsc)Puppeteer's Chromium download is skipped (
PUPPETEER_SKIP_DOWNLOAD) for speed/reliability — the markdown→PDF render tests already self-skip when Chromium can't launch, so the suite stays fast and green while still covering the html/pdf/markdown conversion logic. Enabling the render path later is a one-line change (drop the env var, addnpx puppeteer browsers install chrome).Validated locally: typecheck clean, 22 passed / 2 skipped, build exits 0.
Follow-up (not in this PR)
redeploy_on_buildwas off (now on) — those were the "didn't deploy" half of the same incident.🤖 Generated with Claude Code