Skip to content

feat(core): accessibility date picker - #1043

Merged
aidataba merged 1 commit into
mainfrom
feature/PMI-4098-Accessibility-density-datepicker
Nov 3, 2026
Merged

aidataba merged 1 commit into
mainfrom
feature/PMI-4098-Accessibility-density-datepicker

Conversation

@aidataba

@aidataba aidataba commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change adding per-day native button attributes to the date pickers.

No open issues 🎉

What changed in this PR

Adds per-day native button attributes to Catalyst’s date pickers, allowing consumers to provide accessible descriptions while preserving calendar tab order.

Changes:

  • Adds dayNativeAttributes, keyed by local ISO date, to cat-date and cat-date-inline.
  • Adds unit and browser tests for attribute forwarding, accessible descriptions, keyboard navigation, and focus preservation.
  • Updates public TypeScript declarations, Angular bindings, and component documentation.
File Description
core/​src/​components/​cat-date/​readme.md Documents the new attribute map.
core/​src/​components/​cat-date/​cat-date.tsx Exposes and forwards day attributes to the inline picker.
core/​src/​components/​cat-date/​cat-date.spec.tsx Tests attribute forwarding.
core/​src/​components/​cat-date-inline/​readme.md Documents native day-button attributes.
core/​src/​components/​cat-date-inline/​cat-date-inline.tsx Applies day attributes while retaining control of tab order.
core/​src/​components/​cat-date-inline/​cat-date-inline.spec.tsx Tests attribute propagation, labels, and tab order.
core/​src/​components/​cat-date-inline/​cat-date-inline.e2e.tsx Tests accessible descriptions, keyboard selection, and focus preservation.
core/​src/​components.d.ts Adds the property to component and JSX declarations.
angular/​projects/​catalyst/​src/​lib/​directives/​proxies.ts Exposes the property through both Angular date-picker bindings.

Review effort: Balanced

@aidataba
aidataba merged commit 1003560 into main Nov 3, 2026
9 checks passed
@aidataba
aidataba deleted the feature/PMI-4098-Accessibility-density-datepicker branch November 3, 2026 19:44
@github-actions github-actions Bot mentioned this pull request Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants