Repository navigation
feat(core): accessibility date picker - #1043
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change adding per-day native button attributes to the date pickers.
No open issues 🎉
What changed in this PR
Adds per-day native button attributes to Catalyst’s date pickers, allowing consumers to provide accessible descriptions while preserving calendar tab order.
Changes:
- Adds
dayNativeAttributes, keyed by local ISO date, tocat-dateandcat-date-inline. - Adds unit and browser tests for attribute forwarding, accessible descriptions, keyboard navigation, and focus preservation.
- Updates public TypeScript declarations, Angular bindings, and component documentation.
| File | Description |
|---|---|
core/src/components/cat-date/readme.md |
Documents the new attribute map. |
core/src/components/cat-date/cat-date.tsx |
Exposes and forwards day attributes to the inline picker. |
core/src/components/cat-date/cat-date.spec.tsx |
Tests attribute forwarding. |
core/src/components/cat-date-inline/readme.md |
Documents native day-button attributes. |
core/src/components/cat-date-inline/cat-date-inline.tsx |
Applies day attributes while retaining control of tab order. |
core/src/components/cat-date-inline/cat-date-inline.spec.tsx |
Tests attribute propagation, labels, and tab order. |
core/src/components/cat-date-inline/cat-date-inline.e2e.tsx |
Tests accessible descriptions, keyboard selection, and focus preservation. |
core/src/components.d.ts |
Adds the property to component and JSX declarations. |
angular/projects/catalyst/src/lib/directives/proxies.ts |
Exposes the property through both Angular date-picker bindings. |
Review effort: Balanced
ddoe8
approved these changes
Nov 3, 2026
aidataba
deleted the
feature/PMI-4098-Accessibility-density-datepicker
branch
November 3, 2026 19:44
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.