Repository navigation
secret-guard: read each commit command one way, as the shell does - #187
Merged
Merged
Conversation
plainShape now hands back the command with its heredoc message blanked, and addPaths reads that, so a heredoc can't end in a different place in a later pass. A very long command reads every new file instead of being parsed step by step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #178.
Change
plainShapehands back the command with its heredoc message blanked, andaddPathsreads that string, so no later pass can end the heredoc somewhere else.bare()used to blank single quotes before double ones, so an apostrophe inside double quotes (-m "it's") could pair with a later quote and hide what sat between. It now reads both kinds at once and skips escaped characters, as the shell does. A few commits it used to miss (acd "it's dir", a message with'inside"…") are now checked.<<left anywhere in the command, and on commands over 20,000 characters: every new file is read, as before secret-guard: a commit scans only the untracked files its git add names #178.Tests
claude plugin test mods/secret-guardpasses 40/40, repo tests pass.