Repository navigation
refactor: normalize comments and identifiers - #358
Closed
tenthirtyam wants to merge 1 commit into
Closed
tenthirtyam wants to merge 1 commit into
tenthirtyam wants to merge 1 commit into
Conversation
tenthirtyam
force-pushed
the
refactor/american-english-spellings
branch
from
August 12, 2026 18:09
8d833cc to
196ebb3
Compare
tenthirtyam
force-pushed
the
refactor/american-english-spellings
branch
from
September 9, 2026 13:49
196ebb3 to
fc831fd
Compare
Contributor
Author
|
@tanmay-hc - rebased and ready for review. |
Prefer American English spellings (`-ize`, single `-l-`, `-or`) and "different from", while keeping the public `StateCancelled` key and deprecated option names. Ref: https://www.merriam-webster.com/grammar/canceled-or-cancelled Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
refactor/american-english-spellings
branch
from
November 12, 2026 00:34
fc831fd to
e40920e
Compare
Contributor
Author
|
Superseded by the consolidated cleanup PR: #377. Closing this in favor of that PR per maintainer request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prefer American English spellings (e.g.,
-ize, single-l-,-or).Note:
StateCancelledstays because it's exported and the "cancelled" string is a public state-bag key. Renaming that would break consumers.Ref: https://www.merriam-webster.com/grammar/canceled-or-cancelled
Resolved Issues
Prefer American English spellings.
Rollback Plan
Revert commit.
Changes to Security Controls
None.