Repository navigation
refactor: add explicit defaults in reflect switch blocks - #362
Closed
tenthirtyam wants to merge 1 commit into
Closed
tenthirtyam wants to merge 1 commit into
tenthirtyam wants to merge 1 commit into
Conversation
Add no-op `default` branches with clarifying comments in two reflection-based switch statements (`structTypes` and `renderWalker.Exit`). The compiler does not require exhaustive switches, but unlisted `reflectwalk.Location` and `reflect.Kind `values were left implicit. This documents intentional handling for non-container kinds and keeps the switch logic explicit without changing behavior. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
refactor/explicit-defaults-in-reflect-switch-
branch
from
November 12, 2026 00:34
712cc4a to
2e8c250
Compare
Contributor
Author
|
Superseded by the consolidated cleanup PR: #377. Closing this in favor of that PR per maintainer request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add no-op
defaultbranches with clarifying comments in two reflection-based switch statements (structTypesandrenderWalker.Exit). The compiler does not require exhaustive switches, but unlistedreflectwalk.Locationandreflect.Kindvalues were left implicit.This documents intentional handling for non-container kinds and keeps the switch logic explicit without changing behavior.
Rollback Plan
Revert commit.
Changes to Security Controls
None