Single source of config: ~/.champ/config.yaml only - #128
Merged
Conversation
All configuration now comes from the user-level ~/.champ/config.yaml. The workspace-level .champ/config.yaml is no longer read, written, or watched, so config can't branch per-repo or leak keys into committed projects. - resolveConfig reads only ~/.champ/config.yaml; no workspace fallback. - resolveLayered drops the "workspace-yaml" source/layer entirely (#115 -> #126). - generateConfig, configureProvider wizard, selectModel, firstRunSelect, and the MCP add/delete/install handlers all write to ~/.champ instead of the active workspace folder. - persistProviderSettings (saveSettings / Add-Model) writes to ~/.champ only. - File watcher reloads only on ~/.champ/config.yaml changes. - The repo's .champ/config.yaml is untracked and gitignored to prevent re-committing a workspace config. Tests: layered-source rewritten for the single-source contract; saveSettings test asserts the user-level path. Closes #126
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126
Consolidates all configuration into the user-level ~/.champ/config.yaml and
removes the workspace-local config entirely (per decision: full removal, silent).
and saveSettings (persistProviderSettings) all write to ~/.champ
Branched off master after merging #124; saveSettings now writes to ~/.champ
(superseding the workspace-first path #124 introduced).
Gates: check-types clean, lint 0 errors, 1743 passed / 5 skipped.