fix: reload config changes without window restart - #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #129
Edits to
~/.champ/config.yaml(from a terminal or external tool) were not picked up until a VS Code window restart. The previous watcher relied onvscode.workspace.createFileSystemWatcherrooted atos.homedir()— out-of-workspace watching is unreliable on Linux, so external edits were frequently missed.Changes
src/config/config-watcher.ts— reliable, debounced watcher combining:FileSystemWatcherfast path (in-VS-Code edits) →signalChanged()loadProvider()callsrc/extension.tsrewritten watcher block:ConfigWatcher+ native watcher feed one debounced reload pathtest/unit/config/config-watcher.test.ts— 5 tests (baseline, debounced single reload, collapse rapid changes, no reload on unchanged, deleted-file reload)Tests required
Gates:
pnpm run check-types,pnpm vitest run(1751 pass),pnpm run lint(0 errors)