Repository navigation
Update hightide to 0.18.0, add 10 new languages and round the team realm frame - #19
Merged
Merged
Conversation
- Migrate to context-based translations (HightideProvider translation prop) - Use Select.Option / triggerProps after the Select API change - Register additional locales with English fallback for hightide strings Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
Deploying id-helpwave-de with
|
| Latest commit: |
4afee49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e8966114.id-helpwave-de.pages.dev |
| Branch Preview URL: | https://ccr-35fdca03-cxobv3.id-helpwave-de.pages.dev |
ASCII apostrophes are ICU quote characters and caused 23 messages to be
dropped or mangled (e.g. {{it-IT:backToAccount}}). Use typographic
apostrophes instead and fail check-translations on ASCII apostrophes.
The plural resolver only knows =0/=1/=2/few/many/other, so replace the
unsupported 'one' category in Russian and align Polish/Romanian.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
hightide now ships all 12 locales by default, so the custom supportedLocales list is no longer needed. Keep an English fallback for the few hightide keys that are still untranslated in some locales. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
The frame now starts below the sticky banner and draws its inner edge as a rounded box, so the page content sits inside a rounded card framed by the realm color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn
felixevers
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@helpwave/hightidefrom 0.15.0 to 0.18.0.HightideProvider(translationprop), andsrc/i18n/useTranslation.tsreads them from context. The Storybook preview uses the same setup.LoginOtpto the newSelectAPI:Select.OptionandtriggerProps.src/i18n/hightideConfig.tsadds an English fallback after hightide's translations, so these show in English instead of as{{locale:key}}placeholders.es-ES,fr-FR,it-IT,nl-NL,pl-PL,pt-BR,ro-RO,ru-RU,tr-TR,el-GR.en-USand uses the formal register.=0/=1/=2/few/many/other).check-translationsnow fails on ASCII apostrophes and on unsupported plural categories. The ICU compiler treats'as a quote character and silently dropped messages that contained one, for example{{it-IT:backToAccount}}.Test plan
npm run check-translations,npm run lint,npm run typecheck,npm run build{{…}}placeholders.🤖 Generated with Claude Code
https://claude.ai/code/session_018UdLmpCT1rJ39n1d22CkJn