Repository navigation
Fix CI Codecov upload step that never ran - #40
Merged
Merged
Conversation
The "Upload CodeCov Report" step was conditioned on matrix.os (not a matrix key) and Java 9 (not in the matrix), so coverage was never uploaded. Run it once, on the aarch64/Java 25 entry, upload the JaCoCo XML report produced by the build explicitly, and update codecov-action from v2 to v7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Upload CodeCov Report" step in
build-and-test.ymlnever ran. Its condition wasbut
osis not a key in the macOS job's matrix, and9isn't in thejavalist. This is the same bug as the site step fixed in #39. As a result, nothing was uploaded to Codecov, even though the README has a Codecov badge.Change
ffsampledsp-complete/target/site/jacoco/jacoco.xmlexplicitly, withdisable_search: true. JaCoCo'sreportexecution in the root POM already writes that file duringverify, so the precedinginstallstep produces it. No POM changes are needed.codecov/codecov-actionv7 instead of v2, which is from 2021 and uses a Node runtime GitHub no longer supports.secrets.CODECOV_TOKEN(the secret exists).fail_ci_if_errorstays at its defaultfalse, so a Codecov outage doesn't fail the build.Testing
ffsampledsp-complete/target/site/jacoco/jacoco.xml(~93 KB) with JDK 25.macos-build (aarch64, 25).🤖 Generated with Claude Code