Skip to content

Remove user restriction from Info command - #20

Open
Xieon wants to merge 1 commit into
hexbyt3:mainfrom
Xieon:patch-2
Open

Xieon wants to merge 1 commit into
hexbyt3:mainfrom
Xieon:patch-2

Conversation

@Xieon

@Xieon Xieon commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Removed restriction for a specific user from the Info command.

This users account has been deleted by Discord -
It's impossible for the if statement to ever catch said user, and as such both the constant, and the if statement, can be removed for optimization

image

Summary by CodeRabbit

  • Bug Fixes
    • The bot’s information command no longer rejects a user based on their account ID. The application and bot information lookup now proceeds without that user-specific restriction.

Removed restriction for a specific user from the Info command.
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0e38eb6b-150f-4172-a195-f00c21dc693b
📥 Commits

Reviewing files that changed from the base of the PR and between 1f851ec and b8a133e.

📒 Files selected for processing (1)
  • SysBot.Pokemon.Discord/Commands/General/InfoModule.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

InfoAsync no longer blocks a specific user ID. Callers proceed to the application-info lookup and bot-info response.

Changes

Info command

Layer / File(s) Summary
Remove user-ID rejection
SysBot.Pokemon.Discord/Commands/General/InfoModule.cs
The command no longer checks a specific user ID or sends a rejection to that caller.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to b8a13

The Info command now allows the previously blocked account to use it, matching the stated request; no merge-blocking concern is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the user restriction from the Info command.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🧪 Generate unit tests (beta)
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant