Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The extracted view is missing the required UIKit import and SwiftUI preview.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR moves ConditionalContainerView into its own Swift file and updates Xcode project membership.
Changes:
- Extracts the view from
KioskView.swift. - Adds the standalone view file.
- Updates synchronized project entries and ordering.
File summaries
| File | Description |
|---|---|
Sources/App/Settings/Kiosk/KioskView.swift |
Removes the embedded view. |
Sources/App/Settings/Kiosk/ConditionalContainerView.swift |
Contains the extracted view; needs the UIKit import and a required preview. |
HomeAssistant.xcodeproj/project.pbxproj |
Registers the new file and updates project membership. |
Review details
Suppressed comments (1)
Sources/App/Settings/Kiosk/ConditionalContainerView.swift:138
- This is now a standalone SwiftUI view file, but it has no
#Preview. The project’s SwiftUI convention requires each view to provide a preview (as the neighboring Kiosk views do), so add a representativeConditionalContainerViewpreview here.
}
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Found 3 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.29%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5720 +/- ##
==========================================
- Coverage 42.73% 42.68% -0.06%
==========================================
Files 1123 1124 +1
Lines 77883 77884 +1
==========================================
- Hits 33286 33247 -39
- Misses 44597 44637 +40
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Test coverage of this pull request is below 90%
The unit tests run 73.21% of the lines this pull request
adds or changes (82 of 112 coverable lines).
The per-file breakdown, and the changed lines no test runs, are in the
job summary. Adding tests for those lines and pushing dismisses this
review automatically.
Lines that carry no executable code, and files the unit test targets do not
build, are not counted. If the new code genuinely cannot be unit tested, a
maintainer can dismiss this review.
AI Policy
Select exactly one option that describes AI usage in this contribution:
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes