Add settings deep link - #5729
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking code issues were identified; only a minor documentation-link nit remains.
Pull request overview
Adds a homeassistant://settings deep link that opens the native app settings screen.
Changes:
- Adds settings deep-link routing.
- Adds unit test coverage.
File summaries
| File | Summary |
|---|---|
Tests/App/WebView/IncomingURLHandler.test.swift |
Tests settings deep-link routing. |
Sources/App/Frontend/IncomingURLHandler.swift |
Routes the settings deep link to app settings. |
Review details
Suppressed comments (1)
Sources/App/Frontend/IncomingURLHandler.swift:29
- This adds a user-facing deep-link route, but the required companion documentation PR is still missing from the PR description (
Documentation: home-assistant/companion.home-assistant#). Please add the documentation PR number/link before merging so this new URI is documented as required by the template.
case settings
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Found 3 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5729 +/- ##
==========================================
- Coverage 42.85% 42.83% -0.02%
==========================================
Files 1124 1124
Lines 78170 78172 +2
==========================================
- Hits 33496 33487 -9
- Misses 44674 44685 +11
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AI Policy
Select exactly one option that describes AI usage in this contribution:
Summary
Adds a
homeassistant://settingsdeep link that opens the app settings, using the same path as the "Open app settings" App Intent.Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes