fix(listener): avoid uncaught error when force-closing a non-standard socket - #383
Open
mohamedramadan14 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374.
forceCloseguards with!socket.destroyed, which isundefinedon any socket that is not a realnet.Socket— so the guard passes andsocket.destroySoon()throws. It runs on a timer, so theTypeErrorbecomes anuncaughtExceptionthe caller cannot catch.This feature-detects the teardown method instead:
net.Socketandtls.TLSSocketboth definedestroySoon, so real connections keep the existing graceful-close behaviour unchanged; the check only ever diverges for sockets that could not have serviced the call.cleanup()still runs first on every path, so the timer and listeners are released regardless of which branch is taken.This covers both entry points into
forceClose— theDRAIN_TIMEOUT_MStimer and theMAX_DRAIN_BYTESoverrun.Tests drive
getRequestListenerwith a mocked request whose socket is a bareEventEmitter, matching light-my-request'sMockSocket: one asserts the drain timeout no longer throws, the other that a socket exposing onlydestroyis still torn down.