Skip to content

[PURR][#2812]Display the Review tab and progress notice to user in publication submission process #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kuang5 wants to merge 1 commit into from
Closed

[PURR][#2812]Display the Review tab and progress notice to user in publication submission process #1930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/plugins/projects/publications/language/en-GB/en-GB.plg_projects_publications.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,6 +1044,7 @@ PLG_PROJECTS_PUBLICATIONS_DRAFT_READY_TO_SUBMIT="OK to submit"
PLG_PROJECTS_PUBLICATIONS_ERROR_REGISTER_METADATA="Error registering the DOI metadata and issuing DOI."
PLG_PROJECTS_PUBLICATIONS_ERROR_REGISTER_NAME_URL="Error registering the DOI name and dataset URL."
PLG_PROJECTS_PUBLICATIONS_ERROR_UPDATE_DOI="Failed to update DOI."
PLG_PROJECTS_PUBLICATIONS_PROGRESS_NOTICE="Your dataset is not yet submitted! When you have filled each required field, open the Review tab, then click "Submit draft" to send your dataset to an administrator."

@nkissebe nkissebe Oct 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button name in the resubmit flow. For a curator-returned publication (state 7 / WORKED, which is test step 2 in the description), the Review page renders PLG_PROJECTS_PUBLICATIONS_RESUBMIT_DRAFT ("Re-submit draft to be published"), not "Submit draft" (see views/draft/tmpl/review.php ~line 289). So the notice would tell the user to look for a button that isn't there, which is the stall this PR is meant to fix. Either add a second key for the isWorked() case or make the wording generic (e.g. "click the submit button").

Site-specific wording in the shared core file. "Your dataset" and "an administrator" are PURR phrasing; the rest of this plugin says "publication". PURR already keeps this kind of override in app/bootstrap/site/language/overrides/en-GB.override.ini (e.g. PLG_PROJECTS_PUBLICATIONS_WHATS_NEXT_PENDING), which the translator merges over every loaded file. If a core key is wanted at all, give it generic wording here and put the PURR wording in the override.

@nkissebe nkissebe Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unescaped double quotes inside a double-quoted INI value. This only parses because Translator loads with INI_SCANNER_RAW; the translator's own post-processing (str_replace('\"', '"')) shows the supported convention is \". Any normal-mode parser (default parse_ini_file, external tooling, a future lint) will error on this line and drop the whole file. Please write click \"Submit draft\" or use single quotes.

Placement. This is an informational draft-flow message but it's been added inside the ; Errors block between ERROR_* keys. Move it next to PLG_PROJECTS_PUBLICATIONS_DRAFT_READY_TO_SUBMIT or the other draft-flow strings.

@kuang5 kuang5 Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I forgot to mention that the language change in this PR needs to be combined with the view changes in https://gitlab.hubzero.org/hub-purr/tpl_doi/-/merge_requests/17. All changes together implemented the functionality.


; Misc
PLG_PROJECTS_PUBLICATIONS_REQUIRED="required"
Expand Down