Repository navigation
Component views: look for overrides under the component that owns the… - #1941
Merged
Merged
Conversation
… view A group's wiki renders com_wiki's views inside a com_groups request, so template overrides were searched for under html/com_groups/pages/ and html/com_wiki/pages/ overrides (e.g. wikimenu.php, submenu.php) were ignored. When no override_path is given, derive the component from the view's base_path instead of the request's option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nkissebe
added a commit
that referenced
this pull request
Oct 13, 2026
…ent directories too Component::path() looks for components/wiki before components/com_wiki, so a component directory need not carry the com_ prefix. The helper that #1941 added found the owning component by scanning the view's base path for a com_* segment, which returns nothing for such a directory and left the view falling back to the request's option, the very bug the change fixed for prefixed ones. Take the directory after "components" instead, adding the prefix when it is missing, and keep the com_* scan for paths that are not under a components directory. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… view
Drew comment: Component views that were loaded from a group plugin (like the com_wiki pages) weren't overriding correctly in a supergroup. Claude explains it better than I could below.
Claude comment: A group's wiki renders com_wiki's views inside a com_groups request, so template overrides were searched for under html/com_groups/pages/ and html/com_wiki/pages/ overrides (e.g. wikimenu.php, submenu.php) were ignored. When no override_path is given, derive the component from the view's base_path instead of the request's option.