Repository navigation
Conversation
The TsFile builder imported the third-party `tsfile` SDK inside `_scan_metadata` with no guard, so users and dataset-viewer workers saw a bare `ModuleNotFoundError`. That is also why no `format:tsfile` facet is derived on the Hub (see huggingface#8499). - raise an actionable ImportError pointing at `datasets[tsfile]` - declare the `tsfile` optional extra and install it in the py3.14 tests extra - document the extra in the supported-formats / TsFile loading docs - add a missing-SDK test (existing round-trip tests stay behind importorskip) Refs huggingface#8499, huggingface#8160, huggingface#8256, huggingface#8307
|
Note for the record, since this branch is closed but still linked from #8499. Two things in it did not survive further checking:
Analysis of the pyarrow pins: apache/tsfile#921 (the upper bounds have since been removed upstream in apache/tsfile#922, which is not yet in a stable release). Format-facet analysis: #8499 (comment) Edited 2026-10-07: in the last paragraph, a link to a comment that no longer exists was replaced and the status of apache/tsfile#922 was added; the rest is unchanged. The pyarrow figures in point 2 predate #8502 ( |
Summary
tsfileSDK import behind_require_tsfile()so missing extras raiseImportError: ... pip install 'datasets[tsfile]'instead of a bareModuleNotFoundError.tsfileextra (tsfile>=2.3.0), install it in thetestsextra on Python 3.14 (where it does not conflict withpyarrow>=21), and installdatasets[tsfile]in the py3.14 CI job.loading.mdx,tsfile_load.mdx,about_dataset_load.mdx, and the README.tests/packaged_modules/test_tsfile_optional.pyfor the missing-SDK path. Existing round-trip tests remain behindpytest.importorskip(tsfile).This is the
datasets-side slice of #8499 (see also #8256, #8160, and the overlapping #8307). It does not register a Hubformat:tsfilefacet: that still needs the SDK on every dataset-viewer worker and Hub taxonomy registration.Test plan
pytest tests/packaged_modules/test_tsfile_optional.py(notsfileSDK required)datasets[tsfile]and runstests/packaged_modules/test_tsfile.pypip install 'datasets[tsfile]'thenload_dataset(tsfile, data_files=...)load_dataset(smilegeng/pusht)raises the actionableImportErrorRefs #8499, #8160, #8256, #8307