Repository navigation
Align null struct fields inside lists - #9116
Open
mintcoder-cn wants to merge 1 commit into
Open
mintcoder-cn wants to merge 1 commit into
mintcoder-cn wants to merge 1 commit into
Conversation
concatenate_datasets treated a list of structs with one null field as a different type from the same list with a concrete field. Merge List and LargeList features element by element, the way bare structs already align. Fixes huggingface#9114
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9114
concatenate_datasetsrejects a list of structs when one part inferredValue("null")for a field that has a concrete type in another part. A struct that is not inside a list already aligns in that case._align_featuresonly recursed into dicts, so the two list types were compared as a whole.ListandLargeListfeatures are now merged element by element. A null field takes the other part's type. Two different non-null types still raise.List(Value("null"))alignment is unchanged.Verified with the reproduction in #9114 (
Dataset.from_dicton both orders) and the existing null-list alignment cases.