Repository navigation
Fix pandas missing values becoming "<NA>" or crashing in from_dict (#9117) - #9118
Open
zhengdaodeguL wants to merge 1 commit into
Open
zhengdaodeguL wants to merge 1 commit into
zhengdaodeguL wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9117
When a pandas nullable
Seriescontains a missing value,Dataset.from_dictdoes not preserve it as a null: with an explicit string feature,pd.NAis converted to the literal string"<NA>"; without explicit features the same input raisesArrowTypeError. NullableInt64,Float64, andbooleanSeries raiseTypeErrorduring conversion, and timestamps/durations withNaTfail as well. Arrow itself handles all of these correctly (pa.array(series)givesNone), so the bug is in datasets' Series-to-Python conversion path._cast_to_python_objectsnow normalizespd.NAandpd.NaTtoNonewhen converting aSeries(DataFrame columns use the same path), before recursively casting the values.Tests: new regression coverage for string, nullable integer/float/boolean, timestamp, and duration Series, DataFrame conversion, and
Dataset.from_dictwith and without explicit features. The new tests fail on the unpatched source (16 failures) and pass with the fix; the fulltests/test_arrow_dataset.pyandtests/features/test_features.pyrun is 643 passed, 52 skipped, 6 subtests passed.