Repository navigation
fix(timepicker): hold typed and stepped times inside minValue/maxValue - #132
Merged
Merged
Conversation
A time past the max becomes the max and one before the min becomes the min, as it changes, instead of being left invalid. A first digit waiting for its pair is held once it is completed or its segment is left.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The TimePicker let a typed time go past
minValue/maxValue: it drew it in red and committednull. The arrows also walked past the bounds.Now the draft is held inside the range as it changes:
1on the way to19under a10:00min) is not clamped yet; it is held once completed or when its segment is left. Backspace behaves the same way.The wheels already disabled out-of-range options; they are unchanged.
Tests
Replaced the "flags invalid when out of range" case with clamp cases (typed, pending digit, arrows at min and max).
vitesttimepicker + clock: 204 passing.svelte-check: 0 errors.🤖 Generated with Claude Code