fix(config): correct ROLI system setting IDs and labels - #8
Merged
Conversation
Several labels pointed at unrelated settings, including MPE zone at an axis-tracking ID and swapped glide and slide sensitivities. Replace misleading names and complete the SDK system IDs through 41. Document the Python enum compatibility change and separate hardware brightness from daemon frame brightness. Numeric requests retain their existing behavior; SDK declarations do not prove firmware availability. Independent comparison covers all 38 IDs. The full 518-test Python gate and documentation checks pass. Co-Authored-By: Nova (Codex) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several configuration labels point at unrelated settings: glide and slide sensitivities are swapped, MPE zone points at X tracking mode, and channel labels point at Y/Z tracking. Scripts choosing IDs from
config listcould therefore target the wrong setting.Align the enum with all 38 named system IDs through 41 in the preserved ROLI SDK. Remove misleading names and document their replacements, including the Python import compatibility change. Numeric CLI and API requests continue to send the supplied ID unchanged. The docs distinguish hardware brightness (SDK range 0 to 100) from the daemon's frame brightness (0 to 255).
Independent review matched every enum entry against
roli_BlockConfigId.hand checked the brightness metadata. The full Python gate passes with 518 tests, Ruff, and ty; documentation lint/build also passes. No device settings were written. SDK declarations establish ID meanings, not availability or ranges on every firmware/program.