Repository navigation
Add customer-protected secrets and vault unwrap - #138
Merged
Merged
Conversation
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
Contributor
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: Ninad Sinha <AHarmlessPyro@users.noreply.github.com>
NikhilShahi
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SDK support for customer-protected secrets (browserctrl#1539). The SDK wraps each secret version locally with the customer's own key and unwraps it locally when it's used. It also adds the new wrapped-vault operations and the updated session vault shape.
Changes
createCustomerKey()andCustomerKey:secrets.create({ customerKey | protection })andaddVersion(…, { customerKey })upload{ envelope, innerDigest, innerKid }.secrets.getWrappedVersionandsecrets.unwrap, which returns a pinned{ name, version, unwrapped }reference.secrets.rewrap({ from, to }), which can be resumed if interrupted, andreplaceVersionWrapping.vaults.getWrappedandvaults.unwrap, which returns a vault reference for sandboxes and processes.secretsvaultonePassword.tokenSecret.protectionand the version fieldsouterKidandretiresAt.session.vaults: sessions now attach vaults by reference.tests/fixtures/customer_key_interop.json, with the same keys and envelopes as the Python SDK.Validation
yarn lintyarn typecheckyarn buildyarn test: 883 passed.Note
High Risk
Introduces customer-managed cryptographic wrapping and changes how secrets, vaults, and credentials are serialized and used across sandboxes and sessions—core secrets infrastructure with elevated misuse or validation risk.
Reviewed by Cursor Bugbot for commit bd9fb54. Bugbot is set up for automated code reviews on this repo. Configure here.