Skip to content

fix(hyperdx): rename the DocumentDB TLS files into place - #444

Merged
catinspace-au merged 1 commit into
mainfrom
fix/documentdb-tls-atomic
Nov 21, 2026
Merged

catinspace-au merged 1 commit into
mainfrom
fix/documentdb-tls-atomic

Conversation

@catinspace-au

Copy link
Copy Markdown
Contributor

A restarting container could read a partial file when the one-shot overwrote the CA, key or leaf in place. The one-shot writes each file to a .new name before renaming it into place. It renames the key and leaf first and the CA last.

The rewrite message printed "a running stack serves the old one" on a fresh volume. The message tells you to restart only if the stack is running.

The tests run the one-shot script in a temp directory. A valid pair keeps its sha256 across two runs.

If the CA, key or leaf is empty, the one-shot renews all three in the same directories. No .new file is left behind. openssl verify passes. The renew tests fail on main because the one-shot changes the directory inode.

A restarting container could read a partial file when the one-shot overwrote the CA, key or leaf in place. The one-shot writes each file to a .new name before renaming it into place. It renames the key and leaf first and the CA last.

The rewrite message printed "a running stack serves the old one" on a fresh volume. The message tells you to restart only if the stack is running.

The tests run the one-shot script in a temp directory. A valid pair keeps its sha256 across two runs.

If the CA, key or leaf is empty, the one-shot renews all three in the same directories. No .new file is left behind. openssl verify passes. The renew tests fail on main because the one-shot changes the directory inode.
@catinspace-au
catinspace-au merged commit c48a0c8 into main Nov 21, 2026
16 checks passed
@catinspace-au
catinspace-au deleted the fix/documentdb-tls-atomic branch November 21, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant