Repository navigation
fix(settings): organisation roles, sign-in links and re-auth - #771
Merged
Merged
Conversation
The create and edit forms share their account fields. Organisation assignment sits on its own tab with an explicit choice. Moving an account asks first. On that tab, an account holds Admin or Viewer in its organisation. A crown in the organisation tag marks its admins. Organisation admins see the settings tabs their role covers. Linked identity-provider (IdP) sign-ins show on each account and can be unlinked. A sign-in that matches a local account asks for that account's password to link. Every access change asks "Confirm it's you" first: account, group, role, OIDC provider and API key changes, in Settings and the setup wizard. A local account enters its password. An IdP account signs in again in a popup that hands the grant back to the page. Edit Account gains a Reset Password button, which for your own account goes to your profile. The engine types are synced from dfe-engine.
Group cards and details list the members holding a group through its IdP link after its stored members, each with a link icon. A group held only by link no longer shows "No members assigned".
Next on the Create Account form validates the detail fields before the Organisation tab. A refused check left an unhandled rejection. When Next is refused, the form now stays on Details, where it already marks each failing field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The create and edit forms share their account fields. Organisation assignment sits on its own tab with an explicit choice. Moving an account asks first.
On that tab, an account holds Admin or Viewer in its organisation. A crown in the organisation tag marks its admins. Organisation admins see the settings tabs their role covers.
Linked identity-provider (IdP) sign-ins show on each account and can be unlinked. A sign-in that matches a local account asks for that account's password to link.
Every access change asks "Confirm it's you" first: account, group, role, OIDC provider and API key changes, in Settings and the setup wizard. A local account enters its password. An IdP account signs in again in a popup that hands the grant back to the page. Edit Account gains a Reset Password button, which for your own account goes to your profile.
The engine types are synced from dfe-engine.