Repository navigation
fix(settings): use function matchers for account rows and cells - #774
Merged
Merged
Conversation
The AccountManagement tests built RegExp objects from usernames and display names for Testing Library role name queries. Semgrep flags each RegExp with detect-non-literal-regexp. The tests pass function matchers. The two substring lookups still match with includes(). The cell lookup uses startsWith() to keep the ^ anchor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semgrep flagged three
new RegExp(...)calls in AccountManagement.test.tsx under detect-non-literal-regexp. The fixture usernames and names posed no ReDoS risk here. The CI warning was still open.The role and cell queries use function matchers. The two row lookups keep partial matching with
includes(). The cell lookup usesstartsWith()to keep the^match at the start.On the remote build host,
yarn workspace dfe-core-ui vitest run src/Settings/components/AccountManagementpassed all 47 tests across 9 files. prettier --check passed on the same host. Semgrep ruler/javascript.lang.security.audit.detect-non-literal-regexpreports 3 findings before the change and 0 after.