fix(smash): Wither Image and Inferno draw on the press, and a gate for the class

[andrewgazelka]

Two abilities put nothing on any screen when you pressed them, and the check
that would have caught them could not, for a reason worth writing down.

The two

Wither Image is two presses: the first plants a decoy where you stand, the
second swaps you back to it. Only the swap drew. Planting was silent, so an
opponent could not see that the escape was armed — which is the entire threat
the ability carries. It now plants a column of soul fire, deliberately unlike
the portal shell every teleport uses, so the two presses are told apart at a
glance.

Blaze's Inferno is a half-second-cooldown flame cone and drew nothing at
all. The only fire on screen came from the burn on a victim, so spewing at open
air was invisible and a player could not see where their own flame reached. It
now draws a jet along the facing, above the victim search, because the search
is what can come up empty.

Both are the pattern #1086 was supposed to finish. That commit message says
"the eighth, Wither Image, already draws on the press." It does not, and never
did — I read the second press for the first.

Why no gate caught it

Every sweep we have, the mock one here and the real-client one in
tools/smash-match.py, presses each ability up to three times, because two
abilities in the roster genuinely need more than one. That is correct for the
question those sweeps ask and is exactly why neither could ask this one: the
second press supplied the particles and the first press's silence was invisible.

So every_ability_draws_on_the_press_that_fires_it presses once, and once
only.

The near-miss in the gate itself

Written first against particles alone, it named seven abilities and only one
was a defect:

"Iron Golem / Iron Hook", "Spider / Needler", "Creeper / Sulphur Bomb",
"Wither Skeleton / Guided Wither Skull", "Blaze / Inferno",
"Chicken / Chicken Missile", "Wither Skeleton / Wither Image"

Six of those answer the press by putting a drawn object in the world — a
skull, an egg, a thrown block — and for those the object is the picture. A
check that calls correct code broken is the same error in a mirror, and it is
the worse direction: somebody satisfies it by bolting a redundant puff onto six
working abilities. It now asks whether the press put anything at all on a
screen, by either route, and stays one test because "which abilities are the
projectile kind" is not a list anybody should maintain.

Watched to fail

without the Wither Image fix, particles-only:  7 named, 1 real
without the Wither Image fix, widened:         ["Wither Skeleton / Wither Image"]
with both fixes:                               ok. 13 passed; 0 failed

cargo test -p smash green across all 21 test binaries; cargo fmt --all --check and cargo clippy -p smash --all-targets both clean.

Second commit: clippy has been red on main since #1086

cargo clippy -p smash --lib exits 101 on origin/main at ee1139e:

error: this function could have a `#[must_use]` attribute
  --> events/smash/src/input.rs:260:8

One attribute, from making melee_damage public in #1086. The attribute is not
the interesting part — nothing noticed for four hours, because #1088 turned
every workflow to workflow_dispatch and clippy only ever ran there. It is not
in the nix flake gate, so nix run .#ci, the thing anybody actually runs before
pushing, is green on a tree clippy rejects.

Same hole as ENG-11424, which is the same sentence about cargo fmt --all --check. Both belong in the gate; turning CI off is what made that urgent
rather than tidy.

---

🤖 Opened by Claude Code (claude-opus-4-6).