fix: CodeRabbit auto-fixes for PR #772 - #773
Merged
Merged
Conversation
Fixed 3 file(s) based on 1 failed pre-merge check. Co-authored-by: CodeRabbit <noreply@coderabbit.ai>
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
hyperpolymath
approved these changes
Oct 3, 2026
hyperpolymath
added a commit
that referenced
this pull request
Oct 3, 2026
…ESM corpus (follow-up to #772) (#774) Follow-up to #772 (merged as 8941c87, plus CodeRabbit's doc-comment pass #773). ## Why main is still red With #772's masking fixes in, `build` now reaches step 15 **Run codegen Bun-ESM tests** and stops on one harness: ``` 1 of 32 Bun-ESM harness(es) failed - dom_startup_error.harness.mjs ReferenceError: h is not defined ``` Root cause is in the compiler, not the test: `tests/codegen-deno/dom_startup_error.affine` says `use Dom::{VNode, div, h1, p, text}`, and `stdlib/Dom.affine`'s `div`/`h1`/`p` are one-line wrappers around Dom's own `pub fn h(...)`. `Module_loader.flatten_imports` inlined exactly the named decls and left `h` out of the flattened program, so the emitted module called an undefined `h`. `ImportGlob`/`ImportSimple` already inline every public decl for this reason — `ImportList` was the odd one out. Any consumer writing `use M::{x}` where `x` delegates internally hits this. ## What this does * `lib/module_loader.ml` — close over the named decls' free variables to a fixpoint, pulling the module's own value decls (private helpers included) in dependency order. Aliases keep their behaviour: the closure runs on original names, renaming is applied afterwards. * `lib/ast.ml`, `lib/codegen.ml` — move `find_free_vars` into `ast.ml` (re-exported from `codegen.ml` for existing call sites) so the loader can share the walker instead of adding a fourth private copy. Codegen depends on Module_loader, so the loader could not reach the copy where it lived. ## Verification The OCaml build is the verification (no local toolchain here); the CI run on this PR is the check. Once step 15 passes, steps 16–18 (native Bun-ESM, face transformers, extension.ts) execute for the first time in this pipeline instead of being skipped behind it. ## Before merge The temporary `[diag]` probe (`tools/ci/diag-probe.sh`, `.github/workflows/zz-probe-*.yml`, the `ci.yml` `[diag]` step) is still present — it came in with #772 and is what makes this failure visible without Actions log access. It is deleted in a follow-up commit on this branch once the run is green, so what merges carries no diagnostics scaffolding. --------- Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up PR contains CodeRabbit auto-fixes for #772.
Files modified:
tests/codegen-deno/deno_scripting.harness.mjstests/codegen-deno/deno_scripting_part2.harness.mjstools/run_codegen_bun_tests.sh