fix: restore the Idris2 0.8 package build - #226
Merged
Merged
Conversation
Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 27, 2026 01:41
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the primary Idris2 0.8.0 package build from the SafeRegex frontier through all 305/305 modules.
Core repairs
FFI/API drift repairs
Data.String.splitreturningList1total) and fix a multiline seven-tuple parse failureNatcould otherwise admit themProof-claim repair
Several proof modules were silently treating lowercase exported constants as fresh implicit variables.
%unbound_implicits offnow makes those modules resolve the intended definitions; all six changed proof modules type-check directly.Verification
Executed locally with Idris2 0.8.0 and threaded Chez Scheme 9.6.4:
idris2 --build proven.ipkg— PASS (305/305)idris2 --install proven.ipkg— PASSgit diff --check— PASSThe existing
tests.ipkgsuite is not green yet: it stops inSafeMathPropson stale test APIs (safeAdd,safeSub, oldsafeDivresult assumptions, and related names). That test-suite drift predates these source repairs and is intentionally reported here rather than represented as passing.Scope / follow-up
This PR establishes an honest, compiling primary package baseline. It does not claim that all proof debt is discharged: the repository still contains explicit
OWED:obligations, modules outside the primary package need a separate census/remediation pass, and the stale property suite needs reconciliation.Relates to #184, #203, #204, #208, #209, #210, and #211.