Repository navigation
refactor(root): complete the root cleanup migration - #51
Merged
Merged
Conversation
…ub/hooks/ scripts/check-root-shape.sh flags .githooks/ as root drift — it is not on .machine_readable/root-allow.txt. The estate canon keeps versioned hooks under .github/ (rsr-template-repo made the same move), so the directory is not added to the allowlist; the hooks simply move. Updated the two dogfood-gate invocations that call them, and the .github/ comment in the allowlist to mention hooks/.
Establishes one source of truth for the ABI seam: the package file now sits beside the modules it declares, as in rsr-template-repo. sourcedir is now "." because the package file resolves modules relative to its own directory, which is already src/interface/. Updated every reference (19 total, all accounted for): the Justfile targets, tests/e2e.sh, the four onboarding/status docs, the .gitignore comment, and the allowlist entry — which is dropped, since the file is no longer at root.
…ration The estate-wide migration moved root .well-known/ into www/.well-known/, which creates a tracked www/ directory at the repository root. rsr-template-repo allowlists www/ for exactly this reason (issue #53); this repository's copy of the allowlist was not updated by the migration, so check-root-shape.sh reports it as drift. Entry copied verbatim from the template's allowlist.
…xists The allowlist listed CHANGELOG.md; this repository ships CHANGELOG.adoc. AsciiDoc is the estate-standard documentation format, and the template's own allowlist names CHANGELOG.adoc, so the entry is corrected to match the file on disk rather than the file being renamed.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
hyperpolymath
added a commit
that referenced
this pull request
Sep 18, 2026
Follow-up to #51, applying the same correction the other repos received. `CONTRIBUTING.adoc` and `SECURITY.adoc` are **hard-required at the repo root** by `openssf-compliance.yml` (`test -f`, `exit 1`, no `.github/` fallback) — so they cannot be relocated without weakening that check. The allowlist simply named the `.md` forms instead of the `.adoc` files that exist on disk. Additions only; no files moved. Takes `check-root-shape.sh` from 2 items to green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the half-finished root cleanup (C4).
scripts/check-root-shape.shwas reporting 5 off-allowlist root entries; this takes it to 2, and the 2 that remain are files awaiting an owner ruling (below).What changes:
.githooks/→.github/hooks/— matches the template's layout. The directory held only the two A2ML/K9 validators called bydogfood-gate.yml; both call sites updated.abi.ipkg→src/interface/abi.ipkg— one source of truth for the ABI seam: the package file now sits beside the modules it declares, exactly as inrsr-template-repo.sourcedirbecomes.because the package resolves modules relative to its own directory. All 19 references updated: the Justfile,tests/e2e.sh, four onboarding/status docs, the.gitignorecomment, and the allowlist entry (dropped, since the file is no longer at root).www/allowlisted — created by the estate-wide.well-knownmigration, never listed.CHANGELOGentry corrected — the allowlist namedCHANGELOG.md; this repo shipsCHANGELOG.adoc.What is deliberately left alone — these need your ruling, not a patch:
CONTRIBUTING.adoc—openssf-compliance.yml:52hard-requires a guide at root (exit 1, no.github/fallback), and this repo's own allowlist comment already says dedupe is an owner decision.SECURITY.adoc— same shape; the estate tracks.github/SECURITY.mdas the signposting copy.Verified by running this repository's own
check-root-shape.shbefore and after.