fix(ci,rulesets,triage): execute ULTRAPLAN-2026-09-29 Phase 0–2 fixes and verifications - #1064
Merged
Merged
Conversation
… and verifications - Fix #1050 and #1054 in hypatia-scan-reusable.yml and governance-reusable.yml: remove if: always() from post-validation SARIF/artifact steps, hold past the 4-commit hyperpolymath/hypatia#869 compile-break window on 9f2f62f5c9, and restore single-document jq -e -s validation so clean [] scans pass. - Fix #1040 in scripts/apply-branch-gates.sh and config/rulesets/gates.json: verify candidate gate workflows trigger on pull_request targeting the default branch before deriving job contexts into required_status_checks. - Fix #1036 in scripts/reconcile-scorecard-actions-lock.rb: accept false stale findings for job-level reusable workflow refs and fail closed on Arm-D refs absent from actions.lock. - Fix #1032 (items 3-4) in scripts/apply-tag-ruleset-canon.sh, config/README.adoc, and tests/test_tag_ruleset_canon.sh. - Document github/codeql-action* wildcard hold in docs/DEPENDABOT-POLICY.adoc (#1037 AC5). - Remove orphaned pending-ruling comment in 1-formats/deed/spec/abnf/deed.abnf (#1058) and regenerate .machine_readable/REGISTRY.a2ml. - Repair duplicate cache block in scripts/apply-protection-floor.sh (#1031), sync .github/workflows/actions.lock for #1060, guard empty verifier stdout in scripts/update-actions-lock.sh, and clear retired launcher-standard filename tokens from ULTRAPLAN docs. - Add scripts/triage-2026-09-29-apply.sh + regression test and record Phase 0-2 live verification results in ULTRAPLAN-2026-09-29.adoc. Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
arena-ai-coding-agent
Bot
requested a review
from hyperpolymath
as a code owner
September 29, 2026 08:50
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hyperpolymath
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Executes Phases 0–2 of
ULTRAPLAN-2026-09-29.adoc, repairing the active CI regressions onmainand landing the repo-local fixes and regression suites for the triaged P0/P1/P2 issues:.github/workflows/hypatia-scan-reusable.yml,.github/workflows/governance-reusable.yml,scripts/tests/hypatia-blocking-gate-test.sh,scripts/tests/science-ci-security-test.rb:#1050against runs36504013478and36504013387: upstreamhyperpolymath/hypatiabrokemix escript.buildat4654d7a3d4(hyperpolymath/hypatia#869, unescaped/inside~r/.../character class atlib/rules/pin_integrity.ex:56; last compilable commit is9f2f62f5c9463c79b33a5ebf54372166ce56f349). WhenBuild Hypatia scannerfailed,Relativize finding paths,Filter SARIF through the baseline before upload,Upload SARIF to code scanning, andUpload findings artifactsstill executed due toif: always(), causingUpload SARIF to code scanningto fail on a nonexistenthypatia.sarif(Path does not exist: hypatia.sarif).if: always()from those four post-validation steps (which already sit upstream of the blocking gates), added a targeted hold on9f2f62f5c9463c79b33a5ebf54372166ce56f349for the 4-commithypatia#869broken window (4654d7a3d4..4f9874e3f5) in bothhypatia-scan-reusable.ymlandgovernance-reusable.yml(automatically resumingHEADonce upstreamhypatiaadvances), and restored single-documentjq -e -svalidation inValidate findings and count severitiesso a clean[]scan is a positive control while empty/whitespace/truncated/multi-document output fails closed (#1054).scripts/apply-branch-gates.sh,config/rulesets/gates.json,scripts/tests/branch-gates-apply-test.sh:yaml_has_pr_trigger/wf_triggers_on_prsoapply-branch-gates.shverifies that each candidate gate workflow triggers onpull_request/pull_request_targettargeting the default branch before deriving its job contexts intorequired_status_checks, reportingno_pr_trigger=[<wf>](andUNGATEDif zero contexts survive). Added Case 26 and Mutant J inscripts/tests/branch-gates-apply-test.sh(103/103 passing).scripts/reconcile-scorecard-actions-lock.rb,scripts/tests/reconcile-scorecard-actions-lock-test.rb:ScorecardActionsLockto handle both directions ofgh-actions-lock v0.1.6's blindness to job-level reusable workflowuses:refs: (AC1) acceptingstalefindings whosedependency(owner/repo@ref) is referenced by a job-level reusableuses:in that workflow, and (AC2 / Arm D) failing closed when a workflow's job-level reusableuses:ref is absent from.github/workflows/actions.lock.scripts/apply-tag-ruleset-canon.sh,config/README.adoc,tests/test_tag_ruleset_canon.sh:.source_type == "Repository"before repo-levelPUTinscripts/apply-tag-ruleset-canon.sh(failing closed withREFUSED-NO-SOURCE-TYPEwhen.source_typeis absent and reportingORG-INHERITEDfor.source_type == "Organization"), updatedconfig/README.adoc, and added Property 14 + mutant test intests/test_tag_ruleset_canon.sh(31/31 passing).docs/DEPENDABOT-POLICY.adoc:dependency-name: "github/codeql-action*"trailing-wildcard requirement for subpath actions and its revisit trigger, plus recorded the live 48-PR re-enumeration inULTRAPLAN-2026-09-29.adoc.1-formats/deed/spec/abnf/deed.abnf&.machine_readable/REGISTRY.a2ml:; pending owner ruling. Grammar below is unchanged.line and regenerated.machine_readable/REGISTRY.a2ml(scripts/tests/build-registry-test.sh9/9 passing).mainCI & script repairs:.github/workflows/actions.lockfor#1060(haskell-actions/setup@0f8e8c99d88aeb3fbfd523f1ef2c6f762d10d64dandtailscale/github-action@d1b6cd204f8dceda5b3eaad7f1f767be390056cd) and guardedscripts/update-actions-lock.shagainst empty verifier stdout (scripts/tests/actions-lock-update-test.sh12/12 passing).if [ ! -s "$cache" ]merge artifact inscripts/apply-protection-floor.sh(#1031;scripts/tests/protection-floor-test.sh50/50 passing).launcher-standardfilename tokens fromULTRAPLAN-2026-09-24.adocandULTRAPLAN-2026-09-29.adoc(scripts/tests/check-launcher-standard-currency-test.sh19/19 passing).scripts/triage-2026-09-29-apply.shandscripts/tests/triage-2026-09-29-apply-test.sh.Issue Links (Verified Phase 0 & Phase 1/2 Resolutions)
Closes #1057
Closes #956
Closes #1013
Closes #1005
Closes #637
Closes #709
Closes #715
Closes #784
Closes #1050
Closes #1054
Closes #1040